DO NOT MERGE: test graceful OOM shutdown via intentional memory leak#969
Conversation
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1774888252-memory-failfast-feature-1#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1774888252-memory-failfast-feature-1PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
This comment was marked as outdated.
This comment was marked as outdated.
…-memory-failfast-feature-1
|
/prerelease
|
|
DO NOT MERGE — test graceful OOM shutdown via intentional memory leak This branch introduces an intentional memory leak (500x record duplication into a growing list) to test the CDK's dual-condition memory monitor fail-fast behavior. The corresponding source-faker PR (airbytehq/airbyte#75609) pins the CDK to the dev version from this branch. Expected behavior: The memory monitor should detect cgroup usage ≥ 98% and anonymous memory (via cgroup v2 CDK dev version: |
This PR targets the following PR:
Summary
Adds an intentional memory leak in
AirbyteEntrypoint.read()to test the memory monitor's graceful shutdown behavior (introduced in #962). Each consumed record is duplicated 500× into a growing list to rapidly inflate Python process anonymous RSS, which should trigger the dual-condition fail-fast check.This tests the positive case: the memory monitor should detect and raise
AirbyteTracedExceptionwhen both cgroup usage and process anonymous RSS exceed their respective thresholds.DO NOT MERGE — test-only change to validate memory monitor behavior.
Companion PR: #970 (tests the negative case — cgroup pressure without process RSS growth)
Review & Testing Checklist for Human
AirbyteTracedExceptionat ~98% cgroup + ~90% RssAnonNotes
devin/1774478445-memory-failfast; the other (DO NOT MERGE: test dual-condition monitor with cache-only memory pressure #970) tests that non-process memory pressure does not trigger fail-fastLink to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb